My little recent experiment after being in a team where there are 30PRs to review every day: an npm library that can help you turn your github pull requests into small clips that you can upload in the PR so your team can easily review. (I am not saying you should not check the code anymore, but at least you can visually see quicker what the change should look like).
I would highly appreciate any feedback if you find it useful.
One thing that annoys me is that mapping Jira tickets 1:1 with PRs yields very large PRs that have to be reviewed as a whole. This seems to happen a lot in front-end work, where some PRs touch 40 files or so.
I prefer to keep my PRs under 10 files.
While I was writing this I thought it might be handy to have a counter somewhere (in the zsh prompt or VSCode) showing files and line count for the difference between your branch and the upstream to serve as a reminder of when it’s time to make a PR.
That is a good point. I do have an automation that kicks in when I make a PR that reviews my code at the end and shows me if I have any files above 300 lines.
My little recent experiment after being in a team where there are 30PRs to review every day: an npm library that can help you turn your github pull requests into small clips that you can upload in the PR so your team can easily review. (I am not saying you should not check the code anymore, but at least you can visually see quicker what the change should look like).
I would highly appreciate any feedback if you find it useful.
Cheers!
One thing that annoys me is that mapping Jira tickets 1:1 with PRs yields very large PRs that have to be reviewed as a whole. This seems to happen a lot in front-end work, where some PRs touch 40 files or so.
I prefer to keep my PRs under 10 files.
While I was writing this I thought it might be handy to have a counter somewhere (in the zsh prompt or VSCode) showing files and line count for the difference between your branch and the upstream to serve as a reminder of when it’s time to make a PR.
That is a good point. I do have an automation that kicks in when I make a PR that reviews my code at the end and shows me if I have any files above 300 lines.
> I have any files above 300 lines.
I draw the line at 1000.