Code Reviews, Not Code Approvals

(rethinkingsoftware.substack.com)

7 points | by aard 19 hours ago ago

2 comments

  • WantonQuantum 19 hours ago

    Something else to consider: A code review process can and should be an opportunity for devs to get together and actually talk about the code. This interpersonal interaction leads to learning and team bonding. When the code review is a PR attached to a Jira with the end of a sprint looming, the communication is terse, one-sided and can lead to worse relationships between developers.

    I’m old but I really miss face to face code reviews that allow normal social cues to mediate an experience to make it positive for all parties.

  • eternityforest 16 hours ago

    What would stop people from just not reviewing stuff? If it takes a long time now, wouldn't it still take a long time to review?

    Unless you're going to push unreviewed code to production, it's going to block everything at some point.